Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 11 non-obsolete warnings #5555

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

SpaceManiac
Copy link
Contributor

@SpaceManiac SpaceManiac commented Dec 9, 2024

Pursuant to space-wizards/space-station-14#33279.

Fix:

  • Use optimized TryComp for MetaDataComponent and TransformComponent
  • Remove unused or never-written private variables
  • Remove shadowing nested generics (<T> inside <T>) when the outer <T> is good enough

Silence:

  • Duplicate [Dependency] in tests where it's on purpose
  • Comparing something == itself in tests where it's on purpose

This doesn't fix any warning with "obsolete" in the name, and doesn't fix this monster:

CSC : warning AD0001: Analyzer 'NUnit.Analyzers.DisposeFieldsInTearDown.DisposeFieldsAndPropertiesInTearDownAnalyzer' threw an exception of type 'System.ArgumentException' with message 'Syntax node is not within syntax tree'. [.../RobustToolbox/Robust.UnitTesting/Robust.UnitTesting.csproj]

@PJB3005 PJB3005 merged commit 0c7ace1 into space-wizards:master Dec 13, 2024
3 checks passed
@SpaceManiac SpaceManiac deleted the patch/simple-warnings branch December 13, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants