Monospace Support for Rich Text #5556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
PJB3005
requested changes
Dec 12, 2024
|
This is where all the other elements of rich text are implemented, I assumed this is where it had to go. |
|
ahh it can be implemented there, then I'll do that.a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new
[mono]tag to the RichText system allowing for monospaced text in player-created paper documents.Technical Details
Created the new MonoTag.cs class which handles the [mono] tag when it appears in rich text documents. This loads the Monospace font described in the Prototypes/fonts.yml file and pushes it onto the MarkupDrawingContext object.
Also added the
MonoTagentry to the MarkupTagManager.cs list of valid tags. Forks will need to also need to add this tag to the list of their PaperWindow.xaml.cs_allowedTagsattribute. However, I will be opening a PR on Wizden to account for this so it should propagate neatly.Breaking Changes
If a branch does not have a monospace font defined in its
Resources/Prototypes/fonts.ymland if someone tries to use the[mono]tag in a text document it will likely cause a huge issue. That being said this isn't something that seems to be handled in the similar BoldTag.cs or ItalicTag.cs so I'm gonna assume it's fine.Demonstration
Using the Wizden SS14 debug build.
monospace.mp4