-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Element Call, Livekit Server and JWT Service integrations for Element Call functionality #3562
base: master
Are you sure you want to change the base?
Conversation
Huge PR! Thanks for taking the time to do this! |
My pleasure. |
@wjbeckett
|
@wjbeckett
|
@saket424 Thanks for that. I've just pushed another commit to remove the trailing whitespaces from my files. Hopefully that fixes that up. |
@wjbeckett I get the following error when I try to start PLAY RECAP ************************************************************************************************************************************************************************************************* |
This seemed to fix the undefineds
|
@saket424 ah! I had not updated my dev environment with that patch. I'll fix that now. |
@saket424 Updated pushed that should resolve that error. |
@wjbeckett |
@saket424. Good catch. Updated :-) |
Converting to draft until I can figure out the Matrix Authentication Service integration piece as this is now needed before this can work correctly. JWT service is working as intended, however the call can't connect until it can lookup a user. |
… the element web config.json.
Thanks for doing all this work! 🙇 I haven't reviewed this in detail yet, but:
|
My pleasure @spantaleev. This is my first big PR in any open source project so I'm just happy to helping out however I can.
The JWT broker that manages the integration between livekit and element call is configured to use oidc headers to lookup users. Element-HQ have made it a requirement that MAS is in place for this to be functional. The MAS integration was going to be my next task to try and bring to this playbook.
That's probably a good idea. I'm not across how the two playbooks integrate, but I'm happy to move the livekit over to the mash playbook. |
Can you update the doc to indicate how to generate a live kit dev_key ? I naively thought it was a random string . |
@wjbeckett |
In this file https://github.com/livekit/livekit/blob/master/config-sample.yaml API dev_key and jwt_secret as specified as key1 and key2 respectively. Do you agree that template format roles/custom/matrix-livekit-server/templates/livekit.yaml.j2 needs to be modified to match the sample?
|
The correct syntax for the keypair in roles/custom/matrix-livekit-server/templates/livekit.yaml.j2 is
|
that's correct, however we aren't talking to livekit directly. The JWT service is the one that does the token generation between Matrix and Livekit. |
This Pull Request adds support for deploying Element Call, JWT Service, and Livekit Server as part of the Matrix stack. The changes introduce new roles and corresponding tasks, systemd services, configuration files, and updates to existing configurations to support these new components.
Summary of Changes:
New Roles Added:
Key Additions:
homeserver.yaml
to include listener settings for Element Call.config.json
to include configuration settings for using Element Call.Traefik Configuration:
Tasks and Templates:
config.json
,element.json
,livekit.yaml.j2
, etc.) to provide the correct settings for each service.Testing Performed:
Documentation:
docs
directory to include setup and configuration details for:Limitations:
call.DOMAIN
website for ad-hoc calls will not function correctly until the Matrix Authentication Service (MAS) is implemented. This is due to the requirement of an OIDC header from MAS, which is currently not in place.Checklist:
Notes for Reviewers: