Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VexVulnAssessmentRelationship.md #648

Closed
wants to merge 1 commit into from

Conversation

VenkatTechnologist
Copy link
Contributor

To be precise, VEX as such does not have a version of its own at least as of now. The version (1.0.0 released in April 2023) is for minimum requirements of data elements. Hence suggest this field to reflect precisely what the version field means.

To be precise, VEX as such does not have a version at least as of now. The version (1.0.0 released in April 2023) is for minimum requirements of data elements. Hence suggest this field to reflect precisely what the version field means.
@VenkatTechnologist
Copy link
Contributor Author

There is a key error, and it looks like there are places in code to change if this change is accepted.

Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is need for the property to be renamed, the changes must also be made in the property definition as well.

@VenkatTechnologist
Copy link
Contributor Author

If there is need for the property to be renamed, the changes must also be made in the property definition as well.

Updated properties too, and created a separate pull request for that. Note that default version should be "1.0.0", not zero. Mentioned the same in the property description.

@VenkatTechnologist VenkatTechnologist marked this pull request as draft February 27, 2024 05:09
@goneall goneall added this to the 3.0-rc3 milestone Mar 17, 2024
@goneall
Copy link
Member

goneall commented Apr 3, 2024

@VenkatTechnologist - if PR #649 is still valid - please add this change to PR #649 and close this one

@kestewart kestewart modified the milestones: 3.0-rc3, 3.0 Apr 7, 2024
Copy link
Collaborator

@jeff-schutt jeff-schutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should not change the name of this property. Reason explained here.

@puerco
Copy link
Collaborator

puerco commented Apr 8, 2024

+1 for not changing this property, it is not the version of vex.

@rnjudge
Copy link
Collaborator

rnjudge commented Apr 10, 2024

This PR should be merged with #649. Closing this one so we can continue discussion on 649.

@rnjudge rnjudge closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants