-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VexVulnAssessmentRelationship.md #648
Conversation
To be precise, VEX as such does not have a version at least as of now. The version (1.0.0 released in April 2023) is for minimum requirements of data elements. Hence suggest this field to reflect precisely what the version field means.
There is a key error, and it looks like there are places in code to change if this change is accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is need for the property to be renamed, the changes must also be made in the property definition as well.
Updated properties too, and created a separate pull request for that. Note that default version should be "1.0.0", not zero. Mentioned the same in the property description. |
@VenkatTechnologist - if PR #649 is still valid - please add this change to PR #649 and close this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should not change the name of this property. Reason explained here.
+1 for not changing this property, it is not the version of vex. |
This PR should be merged with #649. Closing this one so we can continue discussion on 649. |
To be precise, VEX as such does not have a version of its own at least as of now. The version (1.0.0 released in April 2023) is for minimum requirements of data elements. Hence suggest this field to reflect precisely what the version field means.