-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset: Rename Dataset class to DatasetPackage and update properties desc. #671
Conversation
@kestewart please kindly review. Some changes (description editing) are opportunistic, I can remove them to make the change set more minimal. fyi @rgopikrishnan91 @bennetkl I have moved the PR here after trying resolve merge conflicts. |
To be deal with in another PR
Remove old description
Remove old description
Break long lines to shorter ones
Small grammar edit
Revise paragraphs
Use only training energy consumption for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup.
Looks good to me. I think can be merged. Thanks @bact ! |
Gopi's ok is in comments, so going ahead and merging. |
Rename
Dataset
class toDatasetPackage
:model.drawio
accordinglyDataset.md
,DatasetPackage.md
,AI.md
,AIPackage.md
to reflect the newDatasetPackage
name.Update other property descriptions:
autonomyType
(actual property name) vs "AutonomyType" (the mention of the property in the beginning of the paragraph).datasetType
was mentioned as "Type". Removing the mention also fixed the inconsistency.Range: xsd:string
, add "A free form text that ..." to the description.