Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URLs in serialization docs to 3.0.1 #849

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Update URLs in serialization docs to 3.0.1 #849

merged 2 commits into from
Sep 10, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 13, 2024 •
edited
Loading

Note that these URLs are not available yet.

We can wait until they are publicly accessible, by the setup of spdx/spdx-spec#1108 .

Update 9 Sep 2024: All the relevant URLs are available now.

@bact
Update URLs in serialization docs to 3.0.1
cb70219 
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact mentioned this pull request Aug 13, 2024
Open
12 tasks
@kestewart kestewart requested a review from zvr August 13, 2024 11:46
@kestewart kestewart added this to the 3.0.1 milestone Aug 13, 2024
@kestewart kestewart added the dependencies Pull requests that update a dependency file label Aug 13, 2024
@kestewart kestewart requested a review from goneall August 13, 2024 11:47
@kestewart kestewart added publishing Dependency for publishing final version of spec and removed dependencies Pull requests that update a dependency file labels Aug 13, 2024
@goneall
Copy link
Member

goneall commented Aug 13, 2024

We should merge this around the same time we update the website with the referenced documents.

@bact bact added the documentation Improvements or additions to documentation label Sep 6, 2024
goneall
goneall approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema and ontology links are now live, we can probably merge them since the remaining IRI changes are not required to link to the documentation.

@bact
Copy link
Collaborator Author

bact commented Sep 10, 2024

Agree. I think we can merge

kestewart
kestewart approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in call, and Bob is ok with us updating these links now.

@kestewart kestewart merged commit 5254f46 into spdx:main Sep 10, 2024
1 check passed
@bact bact deleted the update-301-urls branch September 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@kestewart kestewart kestewart approved these changes

@zvr zvr Awaiting requested review from zvr

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation publishing Dependency for publishing final version of spec
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @goneall @kestewart