Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPDXDocument -> SpdxDocument #851

Merged
merged 1 commit into from
Aug 13, 2024
Merged

SPDXDocument -> SpdxDocument #851

merged 1 commit into from
Aug 13, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 13, 2024

Use actual spelling of the Class

@bact
SPDXDocument -> SpdxDocument
b3c08ff 
Use actual spelling of the Class

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added this to the 3.0.1 milestone Aug 13, 2024
@bact bact requested review from kestewart and goneall August 13, 2024 02:51
goneall
goneall approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

bobmartin3000
bobmartin3000 approved these changes Aug 13, 2024
View reviewed changes
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kestewart
kestewart approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the fact that SPDXDocument went to SpdxDocument at some point in the class. Would have prefered the class to be SPDXDocument as well, but given this is water under the bridge, agree it's best to be consistent.

@kestewart kestewart merged commit 59159fb into spdx:main Aug 13, 2024
1 check passed
@bact bact deleted the fix-typo-relationshiptype branch August 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvr zvr zvr approved these changes

@goneall goneall goneall approved these changes

@kestewart kestewart kestewart approved these changes

@bobmartin3000 bobmartin3000 bobmartin3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@bact @zvr @goneall @kestewart @bobmartin3000