Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGELOG] Add changes in buildType and SpdxOrganization #881

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 13, 2024

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added documentation Improvements or additions to documentation Profile:Core Profile:Build labels Sep 13, 2024
@bact bact added this to the 3.0.1 milestone Sep 13, 2024
@bact bact changed the title Add changes in buildType and SpdxOrganization [CHANGELOG] Add changes in buildType and SpdxOrganization Sep 13, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify that the organization will be used for all "Element types" which is to mean any individual with a type that subclasses Element

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Gary O'Neall <gary@sourceauditor.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Copy link
Collaborator Author

bact commented Sep 13, 2024

Just to clarify that the organization will be used for all "Element types" which is to mean any individual with a type that subclasses Element

Thank you Gary.

I copied that text from the model Markdown file - https://github.com/spdx/spdx-3-model/blob/main/model/Core/Individuals/SpdxOrganization.md - may need to update there as well?

Update: I take this opportunity to update the description there as well in one PR.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact requested a review from goneall September 13, 2024 15:38
@goneall
Copy link
Member

goneall commented Sep 13, 2024

Just to clarify that the organization will be used for all "Element types" which is to mean any individual with a type that subclasses Element

Thank you Gary.

I copied that text from the model Markdown file - https://github.com/spdx/spdx-3-model/blob/main/model/Core/Individuals/SpdxOrganization.md - may need to update there as well?

Update: I take this opportunity to update the description there as well in one PR.

We should update the description in the SpdxOrganization.md file, but we can do that in 3.1 since we've already produced the PDF.

@zvr
Copy link
Member

zvr commented Sep 13, 2024

I am not sure what the difference is.

Do we ever expect to have Individuals that are not Elements? I don't think so.

@bact
Copy link
Collaborator Author

bact commented Sep 13, 2024

If there's no difference, does it mean we're good with what it is now?

(We can merge this after the release)

@goneall
Copy link
Member

goneall commented Sep 13, 2024

I am not sure what the difference is.

Do we ever expect to have Individuals that are not Elements? I don't think so.

Are the enum values technically individuals?

@bact
Copy link
Collaborator Author

bact commented Sep 13, 2024

@goneall
Copy link
Member

goneall commented Sep 15, 2024

Since enums are individuals that do not use the CreationInfo/Organization, it is my opinion that we should clarify which Individuals the SpdxOrganization belongs to.

@bact
Copy link
Collaborator Author

bact commented Sep 24, 2024

@goneall "Element types" added to the description

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@zvr zvr merged commit 0f02dcd into spdx:main Sep 26, 2024
1 check passed
@bact bact deleted the update-changelog-301 branch October 9, 2024 06:40
@bact bact restored the update-changelog-301 branch October 9, 2024 06:40
@bact bact deleted the update-changelog-301 branch October 9, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Profile:Build Profile:Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants