-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHANGELOG] Add changes in buildType and SpdxOrganization #881
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify that the organization will be used for all "Element types" which is to mean any individual with a type that subclasses Element
Co-authored-by: Gary O'Neall <gary@sourceauditor.com> Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Thank you Gary. I copied that text from the model Markdown file - https://github.com/spdx/spdx-3-model/blob/main/model/Core/Individuals/SpdxOrganization.md - may need to update there as well? Update: I take this opportunity to update the description there as well in one PR. |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
We should update the description in the SpdxOrganization.md file, but we can do that in 3.1 since we've already produced the PDF. |
I am not sure what the difference is. Do we ever expect to have Individuals that are not Elements? I don't think so. |
If there's no difference, does it mean we're good with what it is now? (We can merge this after the release) |
Are the enum values technically individuals? |
Likely https://github.com/spdx/spec-parser/blob/main/spec_parser%2Frdf.py#L191-L202 (See line 199) |
Since enums are individuals that do not use the CreationInfo/Organization, it is my opinion that we should clarify which Individuals the SpdxOrganization belongs to. |
@goneall "Element types" added to the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Update the change log with changes from