-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowercase filenames for cleaner URLs #1052
Lowercase filenames for cleaner URLs #1052
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
These two warnings are to be fixed by spdx/spdx-3-model#840 in spdx-3-model
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as soon as it's passing the checks.
@kestewart Warnings fixed in spdx/spdx-3-model#840 -- have to merge that first in spdx-3-model, before this PR can pass the validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have merged spdx/spdx-3-model#840, so trying to get this to sort.
@goneall - can you see if you can get the Validate build working. |
@kestewart it's validated now |
spdx/spdx-3-model#840 was merged, so this can / must be merged for validation to pass |
Note - spdx/spdx-3-model#840 has to be applied first, before this PR.
For cleaner URLs, propose to rename these files:
SPDX-Lite.md
tospdx-lite.md
SPDX-license-expressions.md
tospdx-license-expressions.md
Other files are already in all-lowercase, including ones with a word which originally an all-uppercase initialism:
changes-from-previous-iso.md
(ISO)pkg-url-specification.md
(URL)rdf-model.md
(RDF)The all-lowercase
spdx
will also match the otherspdx
instances in the full URL of:https://spdx.github.io/spdx-spec/...
I'm suggesting we have this before the publication of v3.0.1 website, so the URLs stay the same. (This is not affect the PDF generation)
Will fix #1051 (follow up of #1044 (comment) )