Allow serving swagger-ui as index #1852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @karisN!
Pre-commit is failing. You can install it locally using:
pip install poetry
poetry install --all-extras
pre-commit install
| @@ -151,12 +151,12 @@ async def redirect(request): | |||
| url += "/" | |||
| return RedirectResponse(url=url) | |||
|
|
|||
| self.router.add_route(methods=["GET"], path=console_ui_path, endpoint=redirect) | |||
| self.router.add_route(methods=["GET"], path=console_ui_path or "/", endpoint=redirect) | |||
There was a problem hiding this comment.
I would rather change the way the path is stripped above.
console_ui_path = self.options.swagger_ui_path.strip().rstrip("/") + "/"and removing the leading "/" from the suffixes we add everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow serving swagger-ui as index
Propose fix for #1851