Fix some warnings from unit tests #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now paint using the QPaintEngine of a QImage which removes warnings when running unit tests on Linux.
This removes a warning when running unit tests on Linux.
In CompoundModelBase.handle_items_removed() we took a shortcut and emitted layoutAboutToBeChanged and layoutChanged signals. This doesn't update e.g. a view's current index which causes some warning messages (at least on Linux). We now properly remove the rows using beginRemoveRows() and endRemoveRows().
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2929 +/- ##
==========================================
+ Coverage 66.86% 66.88% +0.01%
==========================================
Files 190 190
Lines 37027 37063 +36
Branches 6355 6367 +12
==========================================
+ Hits 24759 24790 +31
- Misses 10945 10952 +7
+ Partials 1323 1321 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a few warnings when running the unit tests on Ubuntu. This fixes some of those but unfortunately does not help with the segfaults.
Most notably,
CompoundModelBase.handle_items_removed()has been largely rewritten. We now properly callbeginRemoveRows()andendRemoveRows()instead of just recalculating the row and inverse row maps and emittinglayoutChangedwhich left the table views in a somewhat confused state.Re #2921
Checklist before merging