Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks #147

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add pre-commit hooks #147

merged 1 commit into from
Jul 22, 2024

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Jul 22, 2024

Now both isort and black are included in the pre-commit hooks.

Fixes spine-tools/Spine-Toolbox#2897

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Now both isort and black are included in the pre-commit hooks.

Re spine-tools/Spine-Toolbox#2897
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.69%. Comparing base (8da9d87) to head (58c1629).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   62.69%   62.69%           
=======================================
  Files          40       40           
  Lines        3855     3855           
  Branches      767      767           
=======================================
  Hits         2417     2417           
  Misses       1290     1290           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 18782a8 into master Jul 22, 2024
12 checks passed
@PiispaH PiispaH deleted the issue_2897_add_pre_commit_hooks branch July 22, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update precommit hooks to include isort
1 participant