Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gce): add support for hyperdisk in GCE #6288

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

edgarulg
Copy link
Contributor

@edgarulg edgarulg commented Oct 2, 2024

We add hyperdisk-balanced as an option for GCE deployment in Spinnaker. See: https://cloud.google.com/compute/docs/disks/hyperdisks

GoogleDiskType has the available disk types that Spinnaker can deploy. By adding hyperdisk-balanced the instance templates in GCE can now use hyperdisk.

@dbyron-sf
Copy link
Contributor

LGTM. I'd love someone who knows more about the google provider to have a look.

@christosarvanitis
Copy link
Member

Looks good, there is a gotcha with the hyperdisks that only specific instance families are supported but i guess a user requesting hyperdisk is aware of that.

@edgarulg
Copy link
Contributor Author

edgarulg commented Oct 3, 2024

Looks good, there is a gotcha with the hyperdisks that only specific instance families are supported but i guess a user requesting hyperdisk is aware of that.

That is right, Hyperdisk is only supported in specific instance families. The right place to add a validation would be Deck but that is a nice-to-have thing because we assumed the user knows that hyperdisk is for critical instances. Even in the default instances provided by Spinnaker in GCE it doesn't have C3, C4 families to add validations.

The users that will use hyperdisk is not configuring their instances using deck-ui.

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for a merge label Oct 4, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Oct 4, 2024
@mergify mergify bot merged commit 32106c5 into master Oct 4, 2024
24 checks passed
@mergify mergify bot deleted the hyperdisk-persist branch October 4, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.36
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants