feat(kubernetes): Add ServiceAccount provisioning support #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu
force-pushed
the
service-account-support
branch
from
e7af183
to
85c9817
Compare
|
Any chance to get some attention to this? Since spinnaker/spinnaker#5378 was merged, Spinnaker running on EKS should now be able to make use of OIDC enabled roles using service accounts. |
|
@relu would you be able to fix the merge conflicts and we can take another look? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature proposal for provisioning ServiceAccount resources for each deployment type through halyard rather than relying on user provisioned ServiceAccounts via the serviceAccountName setting.
On top of that, having the ability to define ServiceAccount annotations enables us to make use of AWS EKS' OIDC authentication model.