Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): Removed install_aws_cli2 function from Debian post installation script which installs a Debian package within a Debian package causing errors, as well as errors when an aws cli is already installed (#6945) #1088

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix(install): Removed install_aws_cli2 function from Debian post installation script which installs a Debian package within a Debian package causing errors, as well as errors when an aws cli is already installed (#6945) #1088

merged 1 commit into from
Apr 18, 2024

Conversation

ashleykleynhans
Copy link
Contributor

This is a fix for #6945.

  • The post installation script should not attempt to install Debian packages within a Debian package, because the dpg process is already locked by itself and results in errors.
  • If a version of awscli is already installed, it also generates errors.

Therefore the entire function to install aws cli v2 has been removed, and version 2 of the aws cli can be installed manually if it is required.

@ashleykleynhans
fix(install): Removed install_aws_cli2 function from Debian post inst…
4f83d7a 
…allation script which installs a Debian package within a Debian package causing errors, as well as errors when an aws cli is already installed (#6945)
@dbyron-sf
Copy link
Contributor

cc: @jervi since you wrote #1066, but LGTM. cc: @jasonmcintosh as well since you reviewed that PR.

jervi
jervi approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jervi jervi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Apr 18, 2024
@mergify mergify bot added the auto merged label Apr 18, 2024
@mergify mergify bot merged commit 35d0735 into spinnaker:master Apr 18, 2024
4 checks passed
@dbyron-sf
Copy link
Contributor

@Mergifyio backport release-1.34.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 18, 2024 •
edited
Loading

backport release-1.34.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 18, 2024
@ashleykleynhans @mergify
fix(install): Removed install_aws_cli2 function from Debian post inst…
a29d200 
…allation script which installs a Debian package within a Debian package causing errors, as well as errors when an aws cli is already installed (#6945) (#1088)

(cherry picked from commit 35d0735)
@mergify mergify bot mentioned this pull request Apr 18, 2024
Merged
mergify bot added a commit that referenced this pull request Apr 18, 2024
@mergify @ashleykleynhans
fix(install): Removed install_aws_cli2 function from Debian post inst…
626849f 
…allation script which installs a Debian package within a Debian package causing errors, as well as errors when an aws cli is already installed (#6945) (#1088) (#1089)

(cherry picked from commit 35d0735)

Co-authored-by: Ashley Kleynhans <ashleykleynhans@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jervi jervi jervi approved these changes

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.35
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashleykleynhans @dbyron-sf @jervi @spinnakerbot