Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

136 error on non existent word #150

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

kod-kristoff
Copy link
Member

  • refactor: return None on non-existing
  • fix: handle response errors

Bug Fix Title

Issue Description

  • Describe the issue here.

Steps to Reproduce

  • Provide a step-by-step guide to reproducing the issue.

Expected Behavior

  • Describe the expected behavior here.

Solution/Fix Description

-Describe what approaches are taken to fix/mitigate the issue.

Test Cases

  • Detail the test cases you used.
  • Make use of checkboxes to help the developers who is doing the testing keep track of their progress

Additional Information

  • Describe the addition changes/steps you took, for example the SQL commands used for adding a column in database table.

Fixes #136

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.2%. Comparing base (05935b1) to head (42ee6d6).

Additional details and impacted files
Files Coverage Δ
src/sblex/application/services/lookup.py 52.5% <100.0%> (+1.2%) ⬆️
src/sblex/fm_server/api/morph.py 100.0% <100.0%> (ø)
src/sblex/infrastructure/queries/http_morpology.py 100.0% <100.0%> (+14.2%) ⬆️
src/sblex/saldo_ws/routes/fullform_lex.py 100.0% <100.0%> (ø)
src/sblex/trie/trie.py 98.6% <100.0%> (ø)
src/sblex/fm/morphology.py 78.1% <75.0%> (+5.3%) ⬆️

@kod-kristoff kod-kristoff force-pushed the 136-error-on-non-existent-word branch from e27a8e1 to 42ee6d6 Compare June 10, 2024 12:47
@kod-kristoff kod-kristoff merged commit 22ef6e9 into main Jun 12, 2024
12 checks passed
@kod-kristoff kod-kristoff deleted the 136-error-on-non-existent-word branch June 12, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on non-existent word
1 participant