PSR12/FileHeader: make "SpacingAfter" and "SpacingInside" errorcodes modular #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modular This changes the error codes for the `SpacingAfterBlock` and `SpacingInsideBlock` errors to modular error codes which include a reference to the type of header block, i.e. `SpacingAfterDeclareBlock`, `SpacingInsideUseFunctionBlock` etc. This allows for more selective application of the rules. Take for instance the quite common case of the header blocks all being separated by blank lines, except for the open tag and file docblock. ```php <?php /** * File docblock. */ namespace A\B\C; use B\C; ``` The modular errorcodes I'm proposing in this PR will allow for the sniff to be used to safeguard the blank lines between each section without enforcing a blank line between the PHP open tag and the file docblock.
jrfnl
force-pushed
the
feature/psr12-fileheader-more-modular-errorcode-spacing-after
branch
from
7b79003 to
b157f48
Compare
|
Closing as replaced by PHPCSStandards/PHP_CodeSniffer#35 |
jrfnl
deleted the
feature/psr12-fileheader-more-modular-errorcode-spacing-after
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the error codes for the
SpacingAfterBlockandSpacingInsideBlockerrors to modular error codes which include a reference to the type of header block, i.e.SpacingAfterDeclareBlock,SpacingInsideUseFunctionBlocketc.This allows for more selective application of the rules.
Take for instance the quite common case of the header blocks all being separated by blank lines, except for the open tag and file docblock.
The modular errorcodes I'm proposing in this PR will allow for the sniff to be used to safeguard the blank lines between each section without enforcing a blank line between the PHP open tag and the file docblock using:
Fixes #3453