Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kallax.NumericID as PK from serial to bigserial #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaasasolut
Copy link

serial and bigint do not match. serial is 4 bytes long, while bigint is 8 bytes long.
See the documentation of the current version and of the oldest version I could find, 7.2 from 2002.

Because the type of NumericID is int64, I changed serial to bigserial.

Signed-off-by: Abdülhamit Yilmaz <mr.yilmaz@gmx.de>
@roobre
Copy link
Contributor

roobre commented May 2, 2018

Looks nice to me. I'd need to do a quick test to see how this affects migration schemas generated with serial tho, to ensure it is not breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants