Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete several TODOs #535

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Complete several TODOs #535

merged 2 commits into from
Jan 23, 2019

Conversation

EgorBu
Copy link

@EgorBu EgorBu commented Jan 16, 2019

@EgorBu EgorBu force-pushed the todo-fixme branch 2 times, most recently from 79b9825 to 5ac5bbe Compare January 17, 2019 09:04
@EgorBu EgorBu requested a review from m09 January 17, 2019 09:42
Copy link
Contributor

@m09 m09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 only a minor point

lookout/style/format/benchmarks/generate_smoke.py Outdated Show resolved Hide resolved
egor added 2 commits January 18, 2019 14:47
* use dulwich in the future
src-d#526 (comment)
* switch to numpy arrays
src-d#526 (comment)
src-d#526 (comment)

Signed-off-by: egor <egor@sourced.tech>
src-d#535 (comment)

Signed-off-by: egor <egor@sourced.tech>
@vmarkovtsev vmarkovtsev merged commit 3da2c4f into src-d:master Jan 23, 2019
@EgorBu EgorBu deleted the todo-fixme branch April 3, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants