Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added family name, credit name, and other names to record summary #3

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

skybristol
Copy link
Contributor

Great package! Thanks for building this, @sri0606.

I had need for all names to be available in the record summary. This change keeps given-name as the Name property in the summary as that is the only required name that will always be present in an ORCID record, adds properties for "Family Name" and "Credit Name" where those are available (credit name often as the full name and most reasonable label for a person), and adds "Other Names" as a list of the content values from those. I tested this on a range of ORCID identifiers without issue.

I'm going to keep working with my fork in practice and may address the following:

  • Add a parameter for formatting choice on biography to simply include the string value in the record_summary
  • Add parameters to select elements to include in the record_summary

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Please follow the guidelines.

@sri0606 sri0606 merged commit af7f75a into sri0606:main Jan 21, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants