Skip to content

Commit

Permalink
Encourage clarity around what's blocking
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterJCLaw committed Sep 18, 2021
1 parent 21c5048 commit 9c6da4e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ therefore proposed for review:
indicate a review only of some part of the content.

* _Request changes_: responses are blocking and indicate that changes are needed
before content can be merged. Such responses should be rare.
before content can be merged. The review should indicate, either in the
summary comment or in the inline comments, which of the issues raised are
blocking. Such responses should be rare.

In general reviewers are encouraged to bias in favour of merging unless they
feel that the change is particularly sensitive or would be a net negative to the
Expand Down

0 comments on commit 9c6da4e

Please sign in to comment.