[Private Key] Add support for PuTTY private key file format (V3 and V2) #1543
+678
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-xu
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
scott-xu
changed the title
scott-xu
commented
Nov 23, 2024
scott-xu
commented
Nov 23, 2024
| switch (keyType) | ||
| { | ||
| case "ssh-ed25519": | ||
| parsedKey = new ED25519Key(privateKeyReader.ReadBignum2()); |
There was a problem hiding this comment.
ED25519Key class does not have a constructor with both publicKeyData and privateKeyData. The current implementation is to generate public key from private key. Should we add a new constructor?
SSH.NET/src/Renci.SshNet/Security/Cryptography/ED25519Key.cs
Lines 98 to 104 in 3ec45e1
There was a problem hiding this comment.
it seems ok as it is, but I don't mind
Rob-Hague
reviewed
Nov 23, 2024
| switch (keyType) | ||
| { | ||
| case "ssh-ed25519": | ||
| parsedKey = new ED25519Key(privateKeyReader.ReadBignum2()); |
There was a problem hiding this comment.
it seems ok as it is, but I don't mind
scott-xu
force-pushed
the
privatekey-putty
branch
from
7e5d67f to
05547da
Compare
|
ooh a flaky test |
Rob-Hague
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PuTTY private key file format (V3 and V2) described in https://tartarus.org/~simon/putty-snapshots/htmldoc/AppendixC.html
Close #341
Close #431
Close #434
Close #510
Notes:
It may subject to change, then we need to change accordingly. (Hope not). Also hope BouncyCastle makes a formal release before SSH.NET next release.Update: BouncyCastle 2.5.0 is released.