Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom cloze tokens #607

Closed
wants to merge 9 commits into from
Closed

Add custom cloze tokens #607

wants to merge 9 commits into from

Conversation

polyipseity
Copy link
Contributor

@polyipseity polyipseity commented Jan 22, 2023 •
edited
Loading

I have decided to implement custom cloze tokens (closes #556) myself.

For now, I have simply added two text field settings defaulted to empty. Empty means not using any custom cloze tokens. The existing three cloze settings are kept.

Edit: also closes #387

@polyipseity
Add settings to use custom cloze tokens
c056f10 
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Copy link
Contributor Author

polyipseity commented Jan 22, 2023 via email •
edited
Loading

@polyipseity
Format files
79214f0 
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Merge branch 'master' into HEAD
714187e 
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Merge branch 'master' into HEAD
3838151 
Signed-off-by: William So <polyipseity@gmail.com>
@Newdea
Copy link
Contributor

Newdea commented Aug 21, 2023

it seems pretty good, @st3v3nmw hope the master branch will merge it soon.

st3v3nmw
st3v3nmw requested changes Oct 20, 2023
View reviewed changes
Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution 😄!

Sorry the underlying code has gone through a major refactor recently. I'm not sure if you're still available to help resolve the merge conflicts.

Stephen,

@polyipseity
Merge branch 'master' into custom-cloze-tokens
68d1515 
Signed-off-by: William So <polyipseity@gmail.com>

# Conflicts:
#	src/main.ts
#	src/parser.ts
#	tests/unit/parser.test.ts
@polyipseity
Format files
8224b06 
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Fix test errors about translation
7c925e5 
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Fix merge in QuestionType.ts
2960d15 
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Fix merge in QuestionType.ts, attempt 2
aa71f43 
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Copy link
Contributor Author

Done, not too hard.

@MotaOcimar MotaOcimar mentioned this pull request Apr 26, 2024
Closed
5 tasks
@st3v3nmw
Copy link
Owner

Hi,

We ended up going with #943 instead.

I've just made a release (v1.13.0) that ships with custom cloze patterns 🥳 all thanks to #943. The updated documentation is live here.

I'll go ahead and close this PR now.

Cheers.

@st3v3nmw st3v3nmw closed this Oct 13, 2024
@polyipseity polyipseity deleted the custom-cloze-tokens branch October 14, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3v3nmw st3v3nmw Awaiting requested review from st3v3nmw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Custom cloze tokens [FEAT] Adding support for strikethrough/custom cloze
3 participants
@polyipseity @Newdea @st3v3nmw