generated from obsidianmd/obsidian-sample-plugin
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloze Update: Adds Cloze hints, Anki-Like Clozes, Cloze Overlapping and Custom Cloze Patterns #943
Draft
MotaOcimar
wants to merge
4
commits into
st3v3nmw:master
Choose a base branch
from
MotaOcimar:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3bb858a
Allow custom cloze patterns. Also allow numbered clozes (like in anki…
MotaOcimar b1a7009
Merge branch 'st3v3nmw:master' into master
MotaOcimar 02ac1d5
Merge branch 'st3v3nmw:master' into master
MotaOcimar 12ae2ef
Lint and fix failing tests
MotaOcimar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import { ClozeCrafter } from "clozecraft"; | ||
import { CardType } from "./Question"; | ||
|
||
export class ParsedQuestionInfo { | ||
|
@@ -43,15 +44,14 @@ export function parseEx( | |
singlelineReversedCardSeparator: string, | ||
multilineCardSeparator: string, | ||
multilineReversedCardSeparator: string, | ||
convertHighlightsToClozes: boolean, | ||
convertBoldTextToClozes: boolean, | ||
convertCurlyBracketsToClozes: boolean, | ||
clozePatterns: string[], | ||
): ParsedQuestionInfo[] { | ||
let cardText = ""; | ||
const cards: ParsedQuestionInfo[] = []; | ||
let cardType: CardType | null = null; | ||
let firstLineNo = 0; | ||
let lastLineNo = 0; | ||
const clozecrafter = new ClozeCrafter(clozePatterns); | ||
|
||
const lines: string[] = text.replaceAll("\r\n", "\n").split("\n"); | ||
for (let i = 0; i < lines.length; i++) { | ||
|
@@ -96,12 +96,7 @@ export function parseEx( | |
cards.push(new ParsedQuestionInfo(cardType, cardText, firstLineNo, lastLineNo)); | ||
cardType = null; | ||
cardText = ""; | ||
} else if ( | ||
cardType === null && | ||
((convertHighlightsToClozes && /==.*?==/gm.test(currentLine)) || | ||
(convertBoldTextToClozes && /\*\*.*?\*\*/gm.test(currentLine)) || | ||
(convertCurlyBracketsToClozes && /{{.*?}}/gm.test(currentLine))) | ||
) { | ||
} else if (cardType === null && clozecrafter.isClozeNote(currentLine)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
cardType = CardType.Cloze; | ||
|
||
// Explicitly don't change firstLineNo, as we might not see the cloze markers on the first line | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removing the existing settings would break existing instances of the plugin.. There's a
upgradeSettings
function insettings.ts
that would help with gracefully migrating the settings toclozePatterns
.