Merge pull request #964 from stan-dev/pathfinder-init-funs

Pathfinder method errors with init function due to NULL default num_paths
stan-dev · May 7, 2024 · c3d0168 · c3d0168
2 parents 21888fa + 0c2179e
commit c3d0168
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/R/model.R b/R/model.R
@@ -1939,7 +1939,7 @@ pathfinder <- function(data = NULL,
                        history_size = NULL,
                        single_path_draws = NULL,
                        draws = NULL,
-                       num_paths = NULL,
+                       num_paths = 4,
                        max_lbfgs_iters = NULL,
                        num_elbo_draws = NULL,
                        save_single_paths = NULL,

diff --git a/man/model-method-pathfinder.Rd b/man/model-method-pathfinder.Rd
diff --git a/tests/testthat/test-model-pathfinder.R b/tests/testthat/test-model-pathfinder.R
@@ -124,6 +124,11 @@ test_that("pathfinder() method works with init file", {
   expect_pathfinder_output(mod$pathfinder(data = data_file_r, init = init_file))
 })
 
+test_that("pathfinder() method works with init function and default paths", {
+  init_function <- function() { list(theta = 0.5) }
+  expect_pathfinder_output(mod$pathfinder(data = data_file_r, init = init_function))
+})
+
 test_that("pathfinder() method runs when all arguments specified", {
   expect_pathfinder_output(fit <- do.call(mod$pathfinder, ok_arg_values))
   expect_is(fit, "CmdStanPathfinder")