Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rstantools v2.4.0 #118

Merged
merged 6 commits into from
Jan 22, 2024
Merged

rstantools v2.4.0 #118

merged 6 commits into from
Jan 22, 2024

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jan 16, 2024

Getting ready for the next release.

@jgabry
Copy link
Member Author

jgabry commented Jan 16, 2024

@andrjohns I'll run reverse dependency checks locally and if those pass and so do all the checks for this PR then I'll go ahead and submit to CRAN.

@jgabry
Copy link
Member Author

jgabry commented Jan 16, 2024

@andrjohns Do you by any chance have any time to help look into these multiple GHA failures? I've got a ton to catch up on after being away for a while so it might take me some time to get to this.

@andrjohns
Copy link
Collaborator

@andrjohns Do you by any chance have any time to help look into these multiple GHA failures? I've got a ton to catch up on after being away for a while so it might take me some time to get to this.

Perfect timing! I'm waiting for some other stuff to finish running, so I can have a look now

@jgabry
Copy link
Member Author

jgabry commented Jan 16, 2024

Awesome, thanks! I'm also running reverse dependency checks locally and so far the first 15 packages have passed, but there are 128 total, so a while to go still. I also checked on win-builder and that was ok too.

@jgabry
Copy link
Member Author

jgabry commented Jan 17, 2024

@andrjohns A few things:

  1. Looks like your commit fixed the Stanfunctions support checks (thanks!), but there's still a failure on Ubuntu with R-devel. It looks like it's erroring in the vignette, but I tried to reproduce the error and I haven't been able to. Any ideas? If not I can try to do some more digging.

  2. I ran reverse dependency checks on the 100+ packages that use rstantools and they all passed, so we're good to go other than the weird vignette/Ubuntu failure.

@andrjohns
Copy link
Collaborator

2. I ran reverse dependency checks on the 100+ packages that use rstantools and they all passed, so we're good to go other than the weird vignette/Ubuntu failure.

Yeww! Great to hear. I'm also having trouble replicating the Ubuntu devel failure, but I want to dig a little more. Could you try submitting to the win-builder devel and see if there's an error there too?

@andrjohns
Copy link
Collaborator

@jgabry figured it out. For some reason some of the example code in example(source) was throwing an error. But since that was only being called so that the sourceDir function was defined, we can instead just define that directly

@jgabry
Copy link
Member Author

jgabry commented Jan 22, 2024

Awesome, thanks for figuring that out and fixing it

@jgabry
Copy link
Member Author

jgabry commented Jan 22, 2024

I'll go ahead and submit to CRAN

@jgabry jgabry merged commit 77fe508 into master Jan 22, 2024
6 checks passed
@jgabry jgabry deleted the prepare-v2.4.0 branch January 22, 2024 17:07
@jgabry
Copy link
Member Author

jgabry commented Jan 22, 2024

Submitted! I'll tag the release once it's accepted on CRAN.

@jgabry
Copy link
Member Author

jgabry commented Jan 31, 2024

On CRAN now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants