Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): rename EntryPointExecutionContext::new_invoke to n… #1092

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Sep 30, 2024

…ew_execute.


This change is Reviewable

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.98%. Comparing base (b0cfe82) to head (311da37).
Report is 151 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (311da37). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (311da37)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1092       +/-   ##
===========================================
- Coverage   74.18%   62.98%   -11.20%     
===========================================
  Files         359      125      -234     
  Lines       36240    15898    -20342     
  Branches    36240    15898    -20342     
===========================================
- Hits        26886    10014    -16872     
+ Misses       7220     5113     -2107     
+ Partials     2134      771     -1363     
Flag Coverage Δ
62.98% <100.00%> (-11.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meship-starkware meship-starkware force-pushed the meship/bockifier/rename-EntryPointExecutionContext-new_validate branch from 272a487 to a441432 Compare September 30, 2024 08:39
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


crates/blockifier/src/execution/entry_point.rs line 163 at r1 (raw file):

    }

    pub fn new_execution(

Just a suggestion :)

Suggestion:

    pub fn new_validate(
        tx_context: Arc<TransactionContext>,
        limit_steps_by_resources: bool,
    ) -> Self {
        Self::new(tx_context, ExecutionMode::Validate, limit_steps_by_resources)
    }

    pub fn new_execute(

@meship-starkware meship-starkware force-pushed the meship/bockifier/rename-EntryPointExecutionContext-new_validate branch from a441432 to 34a95af Compare September 30, 2024 10:47
@meship-starkware meship-starkware force-pushed the meship/bockifier/rename-EntryPointExecutionContext-new_validate branch from 34a95af to 311da37 Compare September 30, 2024 10:47
@meship-starkware meship-starkware deleted the meship/bockifier/rename-EntryPointExecutionContext-new_validate branch October 1, 2024 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants