Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): impl From AccountTransaction variants for Transaction #1093

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Sep 30, 2024

This change is Reviewable

@meship-starkware meship-starkware force-pushed the meship/blockifier/impl-from-AccountTransaction-variants-for-Transaction branch from c45b829 to 7eba27d Compare September 30, 2024 08:39
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.56%. Comparing base (b0cfe82) to head (bc82a71).
Report is 176 commits behind head on main.

Files with missing lines Patch % Lines
...lockifier/src/transaction/transaction_execution.rs 25.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   74.18%   70.56%   -3.63%     
==========================================
  Files         359       88     -271     
  Lines       36240    11354   -24886     
  Branches    36240    11354   -24886     
==========================================
- Hits        26886     8012   -18874     
+ Misses       7220     2964    -4256     
+ Partials     2134      378    -1756     
Flag Coverage Δ
70.56% <25.00%> (-3.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware force-pushed the meship/blockifier/impl-from-AccountTransaction-variants-for-Transaction branch from 7eba27d to bc82a71 Compare September 30, 2024 10:24
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware merged commit 103f8a5 into main Oct 1, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants