Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(blockifier): avoid repetition in Transaction variant names #1106

Merged

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Sep 30, 2024

This change is Reviewable

@meship-starkware meship-starkware force-pushed the meship/blockifier/shorter-Transaction-variant-name branch from 87e2a62 to 85d75e1 Compare September 30, 2024 08:55
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 59.77%. Comparing base (b0cfe82) to head (85d75e1).
Report is 149 commits behind head on main.

Files with missing lines Patch % Lines
...lockifier/src/transaction/transaction_execution.rs 21.42% 10 Missing and 1 partial ⚠️
...es/blockifier/src/blockifier/stateful_validator.rs 0.00% 0 Missing and 1 partial ⚠️
crates/native_blockifier/src/py_transaction.rs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (85d75e1). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (85d75e1)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1106       +/-   ##
===========================================
- Coverage   74.18%   59.77%   -14.42%     
===========================================
  Files         359      141      -218     
  Lines       36240    16962    -19278     
  Branches    36240    16962    -19278     
===========================================
- Hits        26886    10139    -16747     
+ Misses       7220     6128     -1092     
+ Partials     2134      695     -1439     
Flag Coverage Δ
59.77% <23.52%> (-14.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware merged commit 7096844 into main Sep 30, 2024
12 checks passed
@meship-starkware meship-starkware deleted the meship/blockifier/shorter-Transaction-variant-name branch September 30, 2024 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants