Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_api): resource bounds struct now has typed fields #1168

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 5, 2024

This change is Reviewable

Signed-off-by: Dori Medini <dori@starkware.co>
@dorimedini-starkware dorimedini-starkware self-assigned this Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.62%. Comparing base (e40c65f) to head (1a70c69).

Files with missing lines Patch % Lines
crates/native_blockifier/src/py_transaction.rs 0.00% 2 Missing ⚠️
crates/starknet_api/src/transaction.rs 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           dori/delete-blockifier-gasvector    #1168      +/-   ##
====================================================================
+ Coverage                             67.85%   71.62%   +3.76%     
====================================================================
  Files                                   146      193      +47     
  Lines                                 18107    21815    +3708     
  Branches                              18107    21815    +3708     
====================================================================
+ Hits                                  12286    15624    +3338     
+ Misses                                 4927     4826     -101     
- Partials                                894     1365     +471     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant