chore(blockifier): unify get entry point for V1 and Native

[meship-starkware]

This change is 

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.898 ms 29.955 ms 30.020 ms]
change: [+1.7011% +1.9476% +2.2315%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe

[codecov]

Codecov Report

Attention: Patch coverage is 63.46154% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.89%. Comparing base (b0cfe82) to head (18bab8d).
Report is 326 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/execution/contract_class.rs	65.21%	15 Missing and 1 partial ⚠️
crates/papyrus_protobuf/src/converters/class.rs	0.00%	2 Missing ⚠️
...ates/starknet_api/src/deprecated_contract_class.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   74.18%   70.89%   -3.30%     
==========================================
  Files         359      207     -152     
  Lines       36240    25876   -10364     
  Branches    36240    25876   -10364     
==========================================
- Hits        26886    18344    -8542     
+ Misses       7220     5927    -1293     
+ Partials     2134     1605     -529     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[meship-starkware]

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @noaov1)

---

crates/starknet_client/src/writer/objects/transaction.rs line 27 at r1 (raw file):

    ContractClassAbiEntry as DeprecatedContractClassAbiEntry,
    EntryPointType as DeprecatedEntryPointType,
    EntryPointV0 as DeprecatedEntryPoint,

I'm not sure if it needs to be part of this PR or if we should change the name. I can revert it if you'd like

Code quote:

EntryPointV0

[noaov1]

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @meship-starkware)

---

crates/blockifier/src/execution/contract_class.rs line 72 at r1 (raw file):

    V1(EntryPointV1),
    Native(NativeEntryPoint),
}

I would even consider renaming EntryPointV1 -> CasmEntryPoint (separate PR)

Suggestion:

pub enum Cairo1EntryPoint {
    Casm(EntryPointV1),
    Native(NativeEntryPoint),
}

---

crates/blockifier/src/execution/entry_point_execution.rs line 156 at r1 (raw file):

}

pub fn get_entry_point(

Can you please move it to the contract_class.rs file?

Code quote:

pub fn get_entry_point(

---

crates/blockifier/src/execution/entry_point_execution.rs line 163 at r1 (raw file):

    let entry_points_of_same_type =
        &contract_class.entry_points_of_same_type(call.entry_point_type);

Is this working? If so, you can remove some of th * in the following lines.

Suggestion:

    let entry_points_of_same_type =
        contract_class.entry_points_of_same_type(call.entry_point_type);

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 26 at r1 (raw file):

    ContractClassAbiEntry,
    EntryPointOffset,
    EntryPointType as DeprecatedEntryPointType,

Why is it deprecated?

Code quote:

    EntryPointType as DeprecatedEntryPointType,

[meship-starkware]

Reviewable status: 10 of 12 files reviewed, 3 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/execution/contract_class.rs line 72 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

I would even consider renaming EntryPointV1 -> CasmEntryPoint (separate PR)

Done. Added a Monday task for the refactor.

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 26 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why is it deprecated?

Because the EntryPointType appears in the deprecated_contract_class. I guess the reason is that the deprecated_contract_class file is in starknet_api, and the EntryPointType also appears in the state in starknet_api. So as I see it, we can unify both entry point enum and change the name from deprecated in the imports. Anyway I don't think it should be part of this PR.

---

crates/blockifier/src/execution/entry_point_execution.rs line 156 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Can you please move it to the contract_class.rs file?

Done.

[noaov1]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

[noaov1]

Reviewed 11 of 11 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)