test(blockifier): add case for cairo steps contract

[yoavGrs]

test(blockifier): add case for cairo steps contract

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (b0cfe82) to head (0ca3dbd).
Report is 297 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/test_utils/contracts.rs	5.88%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   74.18%   72.51%   -1.68%     
==========================================
  Files         359       93     -266     
  Lines       36240    12483   -23757     
  Branches    36240    12483   -23757     
==========================================
- Hits        26886     9052   -17834     
+ Misses       7220     3046    -4174     
+ Partials     2134      385    -1749     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @TzahiTaub and @yoavGrs)

---

crates/blockifier/src/test_utils/contracts.rs line 56 at r1 (raw file):

const TEST_CONTRACT_BASE: u32 = 7 * CLASS_HASH_BASE;
const ERC20_CONTRACT_BASE: u32 = 8 * CLASS_HASH_BASE;
const CAIRO_STEPS_TEST_CONTRACT_BASE: u32 = 8 * CLASS_HASH_BASE;

these should be unique

Suggestion:

9 * CLASS_HASH_BASE;

---

crates/blockifier/src/test_utils/contracts.rs line 76 at r1 (raw file):

const ERC20_CAIRO1_CONTRACT_PATH: &str = "./ERC20/ERC20_Cairo1/erc20.casm.json";

// The following contracts atr compiled with a fixed version of the compiler. This compiler version

typo

Code quote:

atr

---

crates/blockifier/src/test_utils/contracts.rs line 232 at r1 (raw file):

            Self::TestContract(_) => TEST_CONTRACT_NAME,
            Self::ERC20(_) => unreachable!(),
            Self::CairoStepsTestContract => CAIRO_STEPS_TEST_CONTRACT_NAME,

keep the unreachable at the end

Suggestion:

            Self::CairoStepsTestContract => CAIRO_STEPS_TEST_CONTRACT_NAME,
            Self::ERC20(_) => unreachable!(),

---

crates/blockifier/src/test_utils/contracts.rs line 282 at r1 (raw file):

            }
            CairoVersion::Cairo1 => {
                let (tag_override, cargo_nightly_arg) = if self.is_legacy() {

is this method still used anywhere?
if not please delete it

Code quote:

self.is_legacy()

[yoavGrs]

Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/blockifier/src/test_utils/contracts.rs line 56 at r1 (raw file):

Previously, dorimedini-starkware wrote…

these should be unique

Oops

---

crates/blockifier/src/test_utils/contracts.rs line 232 at r1 (raw file):

Previously, dorimedini-starkware wrote…

keep the unreachable at the end

Done.

---

crates/blockifier/src/test_utils/contracts.rs line 282 at r1 (raw file):

Previously, dorimedini-starkware wrote…

is this method still used anywhere?
if not please delete it

I already deleted it before

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/blockifier/src/test_utils/contracts.rs line 282 at r1 (raw file):

Previously, yoavGrs wrote…

I already deleted it before

ah, right, my bad