Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): saturate block step bound in max_steps #1289

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 10, 2024

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 10, 2024 08:42
Copy link
Collaborator Author

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (b0cfe82) to head (09933a1).
Report is 308 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/execution/entry_point.rs 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
- Coverage   74.18%   72.38%   -1.81%     
==========================================
  Files         359       93     -266     
  Lines       36240    12440   -23800     
  Branches    36240    12440   -23800     
==========================================
- Hits        26886     9005   -17881     
+ Misses       7220     3047    -4173     
+ Partials     2134      388    -1746     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit efbdf05 into main Oct 10, 2024
12 of 19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants