-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move format_panic_data to starknet-api #1354
Conversation
ec2ba66
to
5efd40b
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
+ Coverage 74.18% 80.08% +5.89%
==========================================
Files 359 95 -264
Lines 36240 12742 -23498
Branches 36240 12742 -23498
==========================================
- Hits 26886 10204 -16682
+ Misses 7220 2093 -5127
+ Partials 2134 445 -1689
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
This is not nessiary if I go with: but I think we do want it here in the long term, wdyt? |
5efd40b
to
94d0797
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to ask @dan-starkware @ShahakShama re the dependency of papyrus_rpc in the blockifier. It doesn't seem right
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
This change is