Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move format_panic_data to starknet-api #1354

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ilyalesokhin-starkware
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware commented Oct 13, 2024

This change is Reviewable

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.851 ms 29.890 ms 29.935 ms]
change: [+1.9323% +2.5957% +3.0769%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.08%. Comparing base (b0cfe82) to head (94d0797).
Report is 363 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
+ Coverage   74.18%   80.08%   +5.89%     
==========================================
  Files         359       95     -264     
  Lines       36240    12742   -23498     
  Branches    36240    12742   -23498     
==========================================
- Hits        26886    10204   -16682     
+ Misses       7220     2093    -5127     
+ Partials     2134      445    -1689     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware
Copy link
Contributor Author

This is not nessiary if I go with:
https://reviewable.io/reviews/starkware-libs/sequencer/1358

but I think we do want it here in the long term, wdyt?

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.906 ms 29.949 ms 29.994 ms]
change: [+2.2042% +2.6813% +3.0579%] (p = 0.00 < 0.05)
Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to ask @dan-starkware @ShahakShama re the dependency of papyrus_rpc in the blockifier. It doesn't seem right
:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware ilyalesokhin-starkware merged commit 8211fbf into main Oct 14, 2024
22 checks passed
@ilyalesokhin-starkware ilyalesokhin-starkware deleted the ilya/format_panic_data branch October 14, 2024 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants