Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean http server module #1443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Oct 15, 2024

No description provided.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.624 ms 34.660 ms 34.701 ms]
change: [-6.6666% -4.9870% -3.4331%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.01%. Comparing base (b0cfe82) to head (b1d4c74).
Report is 424 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
+ Coverage   74.18%   76.01%   +1.82%     
==========================================
  Files         359      359              
  Lines       36240    38422    +2182     
  Branches    36240    38422    +2182     
==========================================
+ Hits        26886    29205    +2319     
+ Misses       7220     6996     -224     
- Partials     2134     2221      +87     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/1c594540 to main October 15, 2024 17:55
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.629 ms 35.014 ms 35.446 ms]
change: [+1.4408% +2.6185% +3.8168%] (p = 0.00 < 0.05)
Performance has regressed.
Found 19 outliers among 100 measurements (19.00%)
2 (2.00%) high mild
17 (17.00%) high severe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants