-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use fully-qualified std::fmt::Display trait #1451
base: main
Are you sure you want to change the base?
Conversation
1e0b8f6
to
227ab9d
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
===========================================
- Coverage 74.18% 54.87% -19.32%
===========================================
Files 359 187 -172
Lines 36240 22511 -13729
Branches 36240 22511 -13729
===========================================
- Hits 26886 12352 -14534
- Misses 7220 8903 +1683
+ Partials 2134 1256 -878
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @MohammadNassar1)
a discussion (no related file):
There are additional uses in crates/starknet_client/src/starknet_error.rs
andcrates/papyrus_rpc/src/version_config.rs
0cf17a2
to
b5adc7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 12 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @MohammadNassar1)
a discussion (no related file):
Previously, ayeletstarkware (Ayelet Zilber) wrote…
There are additional uses in
crates/starknet_client/src/starknet_error.rs
andcrates/papyrus_rpc/src/version_config.rs
Good catch!
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)
b98d860
to
916be18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)
916be18
to
bd3f943
Compare
Benchmark movements: |
To disambiguate from derive_more::Display.
bd3f943
to
bf8fee1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)
To disambiguate from derive_more::Display.