Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fully-qualified std::fmt::Display trait #1451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elintul
Copy link
Collaborator

@elintul elintul commented Oct 15, 2024

To disambiguate from derive_more::Display.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

@elintul elintul force-pushed the elin/refactor/use-fully-qualified-display-trait branch from 1e0b8f6 to 227ab9d Compare October 15, 2024 19:14
Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.287 ms 30.352 ms 30.427 ms]
change: [+1.5177% +1.7866% +2.0529%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) low mild
5 (5.00%) high mild
1 (1.00%) high severe

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.87%. Comparing base (b0cfe82) to head (227ab9d).
Report is 424 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (227ab9d). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (227ab9d)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1451       +/-   ##
===========================================
- Coverage   74.18%   54.87%   -19.32%     
===========================================
  Files         359      187      -172     
  Lines       36240    22511    -13729     
  Branches    36240    22511    -13729     
===========================================
- Hits        26886    12352    -14534     
- Misses       7220     8903     +1683     
+ Partials     2134     1256      -878     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul and @MohammadNassar1)

a discussion (no related file):
There are additional uses in crates/starknet_client/src/starknet_error.rs andcrates/papyrus_rpc/src/version_config.rs


@elintul elintul force-pushed the elin/refactor/use-fully-qualified-display-trait branch 2 times, most recently from 0cf17a2 to b5adc7d Compare October 20, 2024 08:43
Copy link
Collaborator Author

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 12 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware and @MohammadNassar1)

a discussion (no related file):

Previously, ayeletstarkware (Ayelet Zilber) wrote…

There are additional uses in crates/starknet_client/src/starknet_error.rs andcrates/papyrus_rpc/src/version_config.rs

Good catch!
Done.


Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@elintul elintul force-pushed the elin/refactor/use-fully-qualified-display-trait branch 3 times, most recently from b98d860 to 916be18 Compare October 20, 2024 09:29
Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@elintul elintul force-pushed the elin/refactor/use-fully-qualified-display-trait branch from 916be18 to bd3f943 Compare October 20, 2024 09:34
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.708 ms 34.732 ms 34.757 ms]
change: [-5.4374% -3.7358% -2.1922%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

To disambiguate from derive_more::Display.
@elintul elintul force-pushed the elin/refactor/use-fully-qualified-display-trait branch from bd3f943 to bf8fee1 Compare October 20, 2024 11:37
Copy link
Contributor

@ayeletstarkware ayeletstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants