Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): small fixes #1456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (b0cfe82) to head (b2f4e92).
Report is 436 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/execution/syscalls/mod.rs 50.00% 0 Missing and 2 partials ⚠️
...rc/execution/deprecated_syscalls/hint_processor.rs 66.66% 0 Missing and 1 partial ⚠️
...lockifier/src/execution/syscalls/hint_processor.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
- Coverage   74.18%   69.96%   -4.23%     
==========================================
  Files         359      147     -212     
  Lines       36240    18173   -18067     
  Branches    36240    18173   -18067     
==========================================
- Hits        26886    12715   -14171     
+ Misses       7220     4485    -2735     
+ Partials     2134      973    -1161     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.019 ms 30.063 ms 30.111 ms]
change: [-2.8739% -2.1778% -1.6560%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants