Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant clones #1500

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: remove redundant clones #1500

merged 1 commit into from
Oct 21, 2024

Conversation

dan-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.37%. Comparing base (b0cfe82) to head (1db7253).
Report is 453 commits behind head on main.

Files with missing lines Patch % Lines
...arknet_api/src/block_hash/block_hash_calculator.rs 0.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (1db7253). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (1db7253)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1500       +/-   ##
===========================================
- Coverage   74.18%   55.37%   -18.82%     
===========================================
  Files         359      142      -217     
  Lines       36240    20250    -15990     
  Branches    36240    20250    -15990     
===========================================
- Hits        26886    11213    -15673     
- Misses       7220     7853      +633     
+ Partials     2134     1184      -950     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@dan-starkware dan-starkware merged commit f800c3a into main Oct 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants