Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move local deps to root toml #362

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Aug 8, 2024

commit-id:c7e2f0b9


This change is Reviewable

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/build_issues/c7e2f0b9 branch from db75c2a to 9e7211c Compare August 8, 2024 09:12
Copy link

github-actions bot commented Aug 8, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.498 ms 65.579 ms 65.671 ms]
change: [-8.0577% -4.7431% -1.9165%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (41b496e) to head (51a307c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   76.45%   76.48%   +0.02%     
==========================================
  Files         328      328              
  Lines       34816    34816              
  Branches    34816    34816              
==========================================
+ Hits        26619    26628       +9     
+ Misses       5903     5898       -5     
+ Partials     2294     2290       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/blockifier/Cargo.toml line 41 at r1 (raw file):

num-traits.workspace = true
once_cell.workspace = true
papyrus_config = { workspace = true, version = "0.4.0-rc.0" }

version should be controlled by root cargo toml

Suggestion:

papyrus_config.workspace = true

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/build_issues/c7e2f0b9 branch from 9e7211c to 51a307c Compare August 8, 2024 09:34
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/blockifier/Cargo.toml line 41 at r1 (raw file):

Previously, dorimedini-starkware wrote…

version should be controlled by root cargo toml

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware merged commit 8f66c2d into main Aug 8, 2024
72 checks passed
Copy link

github-actions bot commented Aug 8, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.137 ms 65.215 ms 65.308 ms]
change: [-4.6679% -2.9657% -1.6648%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants