Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(fee): tx_context and create_tx_info cannot_fail #538

Merged
merged 1 commit into from
Sep 4, 2024
Merged

build(fee): tx_context and create_tx_info cannot_fail #538

merged 1 commit into from
Sep 4, 2024

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 20, 2024 •
edited by gkaempfer
Loading

This change is Reviewable

@nimrod-starkware Graphite App
Copy link
Contributor Author

nimrod-starkware commented Aug 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nimrod-starkware and the rest of your teammates on Graphite Graphite

@nimrod-starkware nimrod-starkware mentioned this pull request Aug 20, 2024
Merged
@nimrod-starkware nimrod-starkware marked this pull request as ready for review August 20, 2024 13:45
dorimedini-starkware
dorimedini-starkware approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from f48e321 to f2eea66 Compare August 21, 2024 06:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 8a082b1 to 7cbfcf0 Compare August 21, 2024 06:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from f2eea66 to f672171 Compare August 21, 2024 06:42
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 7cbfcf0 to b737eda Compare August 21, 2024 06:42
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from f672171 to 7f86b3c Compare August 21, 2024 06:47
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from b737eda to ac82c9f Compare August 21, 2024 06:47
dorimedini-starkware
dorimedini-starkware approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 7f86b3c to d2705a9 Compare August 21, 2024 07:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from ac82c9f to 43f60d5 Compare August 21, 2024 07:45
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from d2705a9 to 733e6d7 Compare August 21, 2024 08:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 43f60d5 to 02f7ec8 Compare August 21, 2024 08:32
@nimrod-starkware nimrod-starkware mentioned this pull request Aug 21, 2024
Merged
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 733e6d7 to 067e9e9 Compare August 21, 2024 08:40
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 02f7ec8 to eec363c Compare August 21, 2024 08:40
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 067e9e9 to c437bd5 Compare August 21, 2024 08:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from eec363c to d1f5d45 Compare August 21, 2024 08:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from c437bd5 to 50e633b Compare August 21, 2024 11:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from d1f5d45 to 4b7f6f4 Compare August 21, 2024 11:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 50e633b to 286060d Compare August 21, 2024 12:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 4b7f6f4 to 995c2db Compare August 21, 2024 12:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 286060d to 9fd864c Compare August 21, 2024 12:33
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 995c2db to 24d611b Compare August 21, 2024 12:33
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 9fd864c to f47547d Compare August 21, 2024 12:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 24d611b to 2ce1278 Compare August 21, 2024 12:36
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from f47547d to ee302bb Compare August 22, 2024 05:46
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 2ce1278 to 2bf3583 Compare August 22, 2024 05:46
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 473174c to 82bb6f4 Compare September 1, 2024 05:59
dorimedini-starkware
dorimedini-starkware approved these changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from a810387 to 4717ee9 Compare September 3, 2024 06:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 82bb6f4 to c59fd94 Compare September 3, 2024 06:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 4717ee9 to cd20e40 Compare September 3, 2024 13:42
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from c59fd94 to fa7924e Compare September 3, 2024 13:42
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from cd20e40 to 9cc6dd4 Compare September 3, 2024 13:45
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from fa7924e to a3f5653 Compare September 3, 2024 13:45
dorimedini-starkware
dorimedini-starkware approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 9cc6dd4 to c084459 Compare September 3, 2024 13:51
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from a3f5653 to e122e41 Compare September 3, 2024 13:51
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from c084459 to 3d3c960 Compare September 3, 2024 15:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from e122e41 to 69e2d09 Compare September 3, 2024 15:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 3d3c960 to 7fbf370 Compare September 4, 2024 06:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 69e2d09 to deed29a Compare September 4, 2024 06:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 7fbf370 to 391f48d Compare September 4, 2024 07:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from deed29a to 33dc05a Compare September 4, 2024 07:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 391f48d to 05c8794 Compare September 4, 2024 11:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 33dc05a to 0a4a144 Compare September 4, 2024 11:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 05c8794 to 1ef14b7 Compare September 4, 2024 11:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 0a4a144 to 6aec949 Compare September 4, 2024 11:09
@nimrod-starkware Graphite App
Copy link
Contributor Author

nimrod-starkware commented Sep 4, 2024 •
edited
Loading

Merge activity

@nimrod-starkware nimrod-starkware changed the base branch from nimrod/resources_enum/use_in_blockifier to graphite-base/538 September 4, 2024 13:03
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/538 to main September 4, 2024 13:22
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_possible_failure_of_tx_context_creation branch from 6aec949 to 224b23e Compare September 4, 2024 13:23
nimrod-starkware
nimrod-starkware commented Sep 4, 2024
View reviewed changes
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r11, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [48.007 ms 48.250 ms 48.656 ms]
change: [+1.1161% +1.7008% +2.5062%] (p = 0.00 < 0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe

@nimrod-starkware nimrod-starkware merged commit 9745223 into main Sep 4, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

Assignees

@nimrod-starkware nimrod-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimrod-starkware @dorimedini-starkware