Merge main-v0.13.2 into main #589
Conversation
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
* chore(ci): workspace version alignment and tests Signed-off-by: Dori Medini <dori@starkware.co> * chore(ci): split workspace tests into modules Signed-off-by: Dori Medini <dori@starkware.co> --------- Signed-off-by: Dori Medini <dori@starkware.co>
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 3 of 7 files at r3, 15 of 40 files at r4, 28 of 28 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Signed-off-by: Dori Medini <dori@starkware.co>
dorimedini-starkware
requested review from
Itay-Tsabary-Starkware and
Yael-Starkware
Signed-off-by: Dori Medini <dori@starkware.co>
|
Benchmark movements: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 76.40% 76.51% +0.11%
==========================================
Files 349 351 +2
Lines 36999 37043 +44
Branches 36999 37043 +44
==========================================
+ Hits 28268 28344 +76
+ Misses 6402 6376 -26
+ Partials 2329 2323 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 4 of 6 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
….2-into-main-1724654462 (with conflicts)
There was a problem hiding this comment.
Reviewed 4 of 6 files at r6, 2 of 2 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status:
Signed-off-by: Dori Medini <dori@starkware.co>
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @Itay-Tsabary-Starkware, @Yael-Starkware, and @Yoni-Starkware)
crates/starknet_sierra_compile/Cargo.toml line 3 at r8 (raw file):
[package] <<<<<<< HEAD name = "starknet_sierra_compile"
Why was it removed?
Code quote:
name = "starknet_sierra_compile"There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware, @noaov1, @Yael-Starkware, and @Yoni-Starkware)
crates/starknet_sierra_compile/Cargo.toml line 3 at r8 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Why was it removed?
it wasn't, it's sorted now
There was a problem hiding this comment.
Reviewable status:
This change is