Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main-v0.13.2 into main #628

Merged

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 27, 2024

This change is Reviewable

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.52%. Comparing base (dbb8cd7) to head (bc06674).
Report is 9 commits behind head on main.

Files Patch % Lines
crates/native_blockifier/src/py_objects.rs 0.00% 4 Missing ⚠️
crates/native_blockifier/src/py_block_executor.rs 71.42% 2 Missing ⚠️
crates/native_blockifier/src/py_validator.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   76.48%   76.52%   +0.04%     
==========================================
  Files         351      351              
  Lines       37072    37050      -22     
  Branches    37072    37050      -22     
==========================================
- Hits        28354    28352       -2     
+ Misses       6393     6373      -20     
  Partials     2325     2325              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 2 of 3 files at r2, 2 of 3 files at r4, 3 of 7 files at r5, 7 of 7 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware and @nimrod-starkware)

Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@dorimedini-starkware dorimedini-starkware merged commit 6aff64d into main Aug 27, 2024
31 of 57 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants