test(blockifier): intermediate with_attr error message

[aner-starkware]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.15%. Comparing base (7b0dcbc) to head (142721b).
Report is 25 commits behind head on main-v0.13.2.

❗ There is a different number of reports uploaded between BASE (7b0dcbc) and HEAD (142721b). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (7b0dcbc)	HEAD (142721b)
	2	1

Additional details and impacted files

@@               Coverage Diff                @@
##           main-v0.13.2     #630      +/-   ##
================================================
- Coverage         76.46%   71.15%   -5.31%     
================================================
  Files               315       68     -247     
  Lines             34098     9482   -24616     
  Branches          34098     9482   -24616     
================================================
- Hits              26073     6747   -19326     
+ Misses             5763     2325    -3438     
+ Partials           2262      410    -1852     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aner-starkware]

crates/blockifier/feature_contracts/cairo0/test_contract.cairo line 170 at r1 (raw file):

@external
func test_call_contract_with_attr_error_msg{syscall_ptr: felt*}(
    contract_address: felt, function_selector: felt, calldata_len: felt, calldata: felt*

@dorimedini-starkware is there a way to hardcode the variables here? I want to call call_contract with the current contract and the function fail.

Code quote:

contract_address: felt, function_selector: felt, calldata_len: felt, calldata: felt*

[dorimedini-starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @TzahiTaub)

---

crates/blockifier/feature_contracts/cairo0/test_contract.cairo line 170 at r1 (raw file):

Previously, aner-starkware wrote…

@dorimedini-starkware is there a way to hardcode the variables here? I want to call call_contract with the current contract and the function fail.

1. you shouldn't hard-code the address, it depends on the executing code (to which address is it deployed?)
2. selector and calldata - you can probably hard-code, yes

---

crates/blockifier/src/execution/stack_trace_test.rs line 116 at r1 (raw file):

Unknown location (pc=0:{call_location})
Error message: Be aware of failure ahead...
Unknown location (pc=0:{entry_point_location})

shouldn't it be here...?

Suggestion:

Error message: Be aware of failure ahead...
Error at pc=0:37:
Cairo traceback (most recent call last):
Unknown location (pc=0:{call_location})
Unknown location (pc=0:{entry_point_location})

[dorimedini-starkware]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)