Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main-v0.13.2 into main #716

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Sep 5, 2024

This change is Reviewable

@meship-starkware
Copy link
Contributor Author

Src Dst .github/workflows/main.yml

Copy link
Contributor Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r2, 2 of 3 files at r3, 9 of 9 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (5f2a0ff) to head (d8e4732).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   75.82%   71.00%   -4.82%     
==========================================
  Files         352       85     -267     
  Lines       37445    10964   -26481     
  Branches    37445    10964   -26481     
==========================================
- Hits        28392     7785   -20607     
+ Misses       6737     2791    -3946     
+ Partials     2316      388    -1928     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 9 files at r7, 4 of 4 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware force-pushed the meshi/merge-main-v0.13.2-into-main-1725518967 branch from ad52cb8 to f630336 Compare September 5, 2024 07:42
@meship-starkware meship-starkware force-pushed the meshi/merge-main-v0.13.2-into-main-1725518967 branch from f630336 to d8e4732 Compare September 5, 2024 07:43
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@Yoni-Starkware Yoni-Starkware merged commit 35a3320 into main Sep 5, 2024
17 checks passed
@Yoni-Starkware Yoni-Starkware deleted the meshi/merge-main-v0.13.2-into-main-1725518967 branch September 5, 2024 08:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants