Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): moved and renamed compute_discounted_gas_from_gas_… #719

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

amosStarkware
Copy link
Contributor

@amosStarkware amosStarkware commented Sep 5, 2024

…vector


This change is Reviewable

@amosStarkware amosStarkware self-assigned this Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.02%. Comparing base (d7fd3d7) to head (2a19418).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   75.78%   71.02%   -4.77%     
==========================================
  Files         356       88     -268     
  Lines       37762    10929   -26833     
  Branches    37762    10929   -26833     
==========================================
- Hits        28619     7762   -20857     
+ Misses       6848     2779    -4069     
+ Partials     2295      388    -1907     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+reviewer:@TzahiTaub +reviewer:@Yoni-Starkware +reviewer:@nimrod-starkware

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @nimrod-starkware, @TzahiTaub, and @Yoni-Starkware)

Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub and @Yoni-Starkware)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@amosStarkware amosStarkware merged commit c77fb53 into main Sep 8, 2024
16 checks passed
enitrat pushed a commit to kkrt-labs/sequencer that referenced this pull request Sep 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants