-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): moved and renamed compute_discounted_gas_from_gas_… #719
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
- Coverage 75.78% 71.02% -4.77%
==========================================
Files 356 88 -268
Lines 37762 10929 -26833
Branches 37762 10929 -26833
==========================================
- Hits 28619 7762 -20857
+ Misses 6848 2779 -4069
+ Partials 2295 388 -1907 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+reviewer:@TzahiTaub +reviewer:@Yoni-Starkware +reviewer:@nimrod-starkware
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @nimrod-starkware, @TzahiTaub, and @Yoni-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub and @Yoni-Starkware)
88bfba3
to
2a19418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
…vector
This change is