Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): add compiler version to V1ContractClass #730

Merged

Conversation

TzahiTaub
Copy link
Contributor

@TzahiTaub TzahiTaub commented Sep 8, 2024

This change is Reviewable

@TzahiTaub TzahiTaub marked this pull request as ready for review September 8, 2024 10:39
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @TzahiTaub and the rest of your teammates on Graphite Graphite

@TzahiTaub TzahiTaub force-pushed the tzahi/blockifier/add_compiler_version_to_V1ContractClass branch from 57872d9 to 7ef0c68 Compare September 8, 2024 10:42
@TzahiTaub TzahiTaub self-assigned this Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.68%. Comparing base (1d3d0fc) to head (7ef0c68).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   76.07%   70.68%   -5.40%     
==========================================
  Files         356       88     -268     
  Lines       37871    11017   -26854     
  Branches    37871    11017   -26854     
==========================================
- Hits        28811     7787   -21024     
+ Misses       6751     2842    -3909     
+ Partials     2309      388    -1921     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@TzahiTaub TzahiTaub merged commit 91835a9 into main Sep 15, 2024
16 checks passed
@TzahiTaub TzahiTaub deleted the tzahi/blockifier/add_compiler_version_to_V1ContractClass branch September 15, 2024 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants