test(blockifier): estimate_minimal_gas_vector depends on GasVectorComputationMode

[aner-starkware]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (d39e13b) to head (6785d32).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   76.17%   70.59%   -5.58%     
==========================================
  Files         359       88     -271     
  Lines       38294    11053   -27241     
  Branches    38294    11053   -27241     
==========================================
- Hits        29169     7803   -21366     
+ Misses       6796     2862    -3934     
+ Partials     2329      388    -1941     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aner-starkware and @nimrod-starkware)

---

crates/blockifier/src/transaction/transactions_test.rs line 829 at r1 (raw file):

#[rstest]
fn test_estimate_minimal_gas_vector(
    mut block_context: BlockContext,

if you do this, can you remove the let block_context = &block_context; below?

Suggestion:

block_context: &mut BlockContext,

---

crates/blockifier/src/transaction/transactions_test.rs line 865 at r1 (raw file):

    } else {
        assert_eq!(minimal_l1_data_gas, 0);
    }

equivalent, and hopefully less lines

Suggestion:

    assert_eq!(minimal_l2_gas > 0, gas_vector_computation_mode == GasVectorComputationMode::All);
    assert_eq!(minimal_l1_data_gas > 0, use_kzg_da);

[aner-starkware]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @nimrod-starkware)

---

crates/blockifier/src/transaction/transactions_test.rs line 829 at r1 (raw file):

Previously, dorimedini-starkware wrote…

if you do this, can you remove the let block_context = &block_context; below?

The compiler is not a fan of this...

---

crates/blockifier/src/transaction/transactions_test.rs line 865 at r1 (raw file):

Previously, dorimedini-starkware wrote…

equivalent, and hopefully less lines

Nice! Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)