Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed instructions to components in Adapter #111

Open
wants to merge 1 commit into
base: yuval/adapted_stwo_log_cairo_input
Choose a base branch
from

Conversation

yuvalsw
Copy link
Collaborator

@yuvalsw yuvalsw commented Oct 8, 2024

This change is Reviewable

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 3 unresolved discussions (waiting on @yuvalsw)

a discussion (no related file):
About that naming:
All Cairo instructions/ builtins have a corresponding component.
There are also components that are not related to an instruction (e.g. blake_round component)

WDYT about vm_components?



stwo_cairo_prover/crates/adapted_prover/src/main.rs line 66 at r1 (raw file):

        import_from_vm_output(args.pub_json.as_path(), args.priv_json.as_path())?;

    let component_counts = vm_output.components_usage.counts();

Re my comment above, this won't contain all the components.

Code quote:

let component_counts = vm_output.components_usage.counts();

stwo_cairo_prover/crates/prover/src/input/components_usage.rs line 31 at r1 (raw file):

/// no ap++ (0=false). Note: for the flag "fp/ap", true means fp-based and false means ap-based.
#[derive(Debug, Default)]
pub struct ComponentsUsage {

WDYT?
I don't think the word usage fits here well

Suggestion:

pub struct VMComponents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants