-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all MLE eval related constraints into same module #798
Move all MLE eval related constraints into same module #798
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #798 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 91 91
Lines 12442 12442
Branches 12442 12442
=======================================
Hits 11479 11479
Misses 857 857
Partials 106 106 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r1, all commit messages.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 10 at r1 (raw file):
use crate::core::lookups::utils::eq; /// Evaluates constraints that grantee a MLE evaluates to a claim at a given point.
Suggestion:
Evaluates constraints that guarantee an MLE evaluates to a claim at a given point.
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 14 at r1 (raw file):
/// `mle_coeffs_col_eval` should be the evaluation of the column containing the coefficients of the /// MLE in the multilinear Lagrange basis. `mle_claim_shift` should equal `claim / 2^N_VARIABLES`. pub fn eval_mle_eval_constrants<E: EvalAtRow, const N_VARIABLES: usize>(
Suggestion:
eval_mle_eval_constraints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 6 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)
e0f1063
to
41485b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
crates/prover/src/examples/xor/gkr_lookups/mle_eval.rs
line 10 at r1 (raw file):
use crate::core::lookups::utils::eq; /// Evaluates constraints that grantee a MLE evaluates to a claim at a given point.
Done.
This change is