Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FRI layer 0 (WIP) #895

Conversation

andrewmilson
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@andrewmilson andrewmilson changed the title Add FRI layer 0 Add FRI layer 0 (WIP) Nov 19, 2024
Copy link
Contributor Author

andrewmilson commented Nov 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.89796% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (09-23-Return_opening_positions_and_query_positions_per_column_size_in_FRI@2811e40). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/prover/src/core/pcs/quotients.rs 91.17% 3 Missing and 3 partials ⚠️
crates/prover/src/core/prover/mod.rs 60.00% 6 Missing ⚠️
crates/prover/src/core/fri.rs 96.66% 1 Missing ⚠️
crates/prover/src/core/pcs/prover.rs 98.57% 1 Missing ⚠️
crates/prover/src/core/pcs/verifier.rs 97.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                             Coverage Diff                                              @@
##             09-23-Return_opening_positions_and_query_positions_per_column_size_in_FRI     #895   +/-   ##
============================================================================================================
  Coverage                                                                             ?   91.69%           
============================================================================================================
  Files                                                                                ?       90           
  Lines                                                                                ?    12733           
  Branches                                                                             ?    12733           
============================================================================================================
  Hits                                                                                 ?    11676           
  Misses                                                                               ?      942           
  Partials                                                                             ?      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 33ffc16 Previous: f6214d1 Ratio
merkle throughput/simd merkle 30833460 ns/iter (± 531466) 14690867 ns/iter (± 434150) 2.10

This comment was automatically generated by workflow using github-action-benchmark.

CC: @spapinistarkware

@andrewmilson andrewmilson force-pushed the 11-19-Add_FRI_layer_0 branch 2 times, most recently from 66e9955 to 48d939a Compare November 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants